[Asterisk-code-review] formats: Changed file-block reading from 20ms to 10ms. (asterisk[11])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: formats: Changed file-block reading from 20ms to 10ms.
......................................................................


Patch Set 1:

> I think Corey and Josh are correct. This patch - while it may fix a
 > problem that some users have - has a greater risk of causing
 > problems that affect more users. At the very least, I don't think
 > it is appropriate to be included in 11 and 13.
 > 
 > For master, I think it might be appropriate as a compile time only
 > option, triggered in the build options of menuselect. For those who
 > *really* want a multiple of 10ms, they could conditionally compile
 > that in, without affecting the performance of other Asterisk users.
 > I'm not usually a big fan of compile time options, but that seems
 > like the only compromise where this could be used by those who need
 > it without seriously affecting a large portion of the userbase.

Instead of a menuselect option we could use a define in a header:
#ifndef AST_FORMAT_READ_MS
#define AST_FORMAT_READ_MS 20
#endif

Then update this patch to use that define to calculate buffer sizes and read lengths.  This way CFLAGS can be used to override the default value of 20, allowing for 5 or 10 to be used.  I think this option will be very rarely used that is why I'm not a fan of adding a menuselect option.

-- 
To view, visit https://gerrit.asterisk.org/1460
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5aa21a3c4f3a4ea78ac3cc80a3883317648464a4
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No