[Asterisk-code-review] res pjsip outbound registration: registration stops due to f... (asterisk[certified/13.1])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_outbound_registration: registration stops due to fatal 4xx response
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1474/4/contrib/ast-db-manage/config/versions/28ce1e718f05_add_fatal_response_interval.py
File contrib/ast-db-manage/config/versions/28ce1e718f05_add_fatal_response_interval.py:

Line 11: down_revision = '26f10cadc157'
Alembic series for v13 is incorrect as there are branches.

rmudgett at piglet:~/projects/asterisk/certified/v13.x/contrib/ast-db-manage ((no branch))$ alembic branches
/usr/local/lib/python2.7/dist-packages/alembic/util.py:182: UserWarning: Revision 26f10cadc157 referenced from 26f10cadc157 -> 28ce1e718f05 (head), add fatal_response_interval is not present
  warnings.warn(msg)
/usr/local/lib/python2.7/dist-packages/alembic/util.py:182: UserWarning: Revision 26f10cadc157 referenced from 26f10cadc157 -> 154177371065 (head), add default_from_user is not present
  warnings.warn(msg)

The procedure described here needs to be followed:
https://wiki.asterisk.org/wiki/display/AST/Merging+alembic+scripts


https://gerrit.asterisk.org/#/c/1474/4/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:

Line 108: 						retry after receiving a fatal (non-temporary 4xx, 5xx, 6xx) response.
        :                                                 Setting this to a non-zero value may go against a "SHOULD NOT" in RFC3261,
        :                                                 but can be used to work around buggy registrars.</para>
        : 						<note><para>if also set the <replaceable>forbidden_retry_interval</replaceable>
        :                                                 takes precedence over this one when a 403 is received.
        :                                                 Also, if <replaceable>auth_rejection_permanent</replaceable> equals 'yes' then
        :                                                 a 401 and 407 become subject to this retry interval.</para></note>
spaces instead of tabs used on several lines here


-- 
To view, visit https://gerrit.asterisk.org/1474
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc2c7b47164ac89cc803433c0bbe7063bfa143a2
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes