[Asterisk-code-review] res pjsip: Add "like" processing to pjsip list and show com... (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: res_pjsip:  Add "like" processing to pjsip list and show commands
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1476/2/CHANGES
File CHANGES:

Line 187: ------------------------------------------------------------------------------
        : --- Functionality changes from Asterisk 13.6.0 to Asterisk 13.7.0 ------------
        : ------------------------------------------------------------------------------
        : 
        : res_pjsip
        : ------------------
        :  * The ability to use "like" has been added to the pjsip list and show
        :    CLI commands.  For instance: CLI> pjsip list endpoints like abc
        : 
        : ------------------------------------------------------------------------------
        : --- Functionality changes from Asterisk 13.6.0 to Asterisk 13.7.0 ------------
        : ------------------------------------------------------------------------------
Looks like the header got duplicated. Prob due to a merge. Looks like there are/were several other things currently up for review trying to do something similar.


https://gerrit.asterisk.org/#/c/1476/2/res/res_pjsip_endpoint_identifier_ip.c
File res/res_pjsip_endpoint_identifier_ip.c:

Line 340: 	if (ao2_container_dup(s_container, container, 0)) {
        : 		return NULL;
        : 	}
This off nominal path looks like it leaks the s_container.


-- 
To view, visit https://gerrit.asterisk.org/1476
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I646d9326b778aac26bb3e2bcd7fa1346d24434f1
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes