[Asterisk-code-review] funcs/func holdintercept: Actually add the HOLD INTERCEPT fu... (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: funcs/func_holdintercept: Actually add the HOLD_INTERCEPT function
......................................................................


Patch Set 1:

> Should this build by default in 13?  I'm indifferent but I thought
 > new modules were disabled by default for already released branches.

Nope, we don't have a hard and fast policy for that. Only for tests - the test for this was merged way back when and still passes when the module exists.

We would make a module disabled by default if there was a risk of it introducing some kind of regression. Since this module is passive unless invoked explicitly, that doesn't seem to be the case.

-- 
To view, visit https://gerrit.asterisk.org/1453
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida38278f259dd07c334a36f9b7d5475b5db72396
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No