[Asterisk-code-review] Confbridge test failures due to scenarios sometimes ending t... (testsuite[master])

[Kevin Harwell]

Hello Anonymous Coward #1000019, Matt Jordan,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/1390

to look at the new patch set (#2).

Change subject: Confbridge test failures due to scenarios sometimes ending too early
......................................................................

Confbridge test failures due to scenarios sometimes ending too early

A few confbridge tests would sporadically fail because the scenario(s) would
end before all events had been processed. This happened because an "end"
scenario action was tied to a specific event, so once that event was received
it triggered the scenario to end. The test would end, but sometimes there
were available events still left to process.

This patch makes it so the test scenario will not end until all expected events
have been received and their actions have been run, or a timeout occurs. It
also makes it so that in the case when an event is received more than once any
actions are run only one time (upon reception of the first event).

Change-Id: I3e067f7cd80568c9b507ca850771040d5fe2f593
---
M lib/python/asterisk/apptest.py
M tests/apps/agents/agent_acknowledge/agent_acknowledge_error/test-config.yaml
M tests/apps/agents/agent_acknowledge/nominal/test-config.yaml
M tests/apps/agents/agent_login/login_errors/test-config.yaml
M tests/apps/agents/agent_login/nominal/test-config.yaml
M tests/apps/agents/agent_request/nominal/test-config.yaml
M tests/apps/authenticate/off_nominal/test-config.yaml
M tests/apps/bridge/bridge_wait/bridge_wait_e_options/test-config.yaml
M tests/apps/bridge/bridge_wait/bridge_wait_roles/test-config.yaml
M tests/apps/bridge/bridge_wait/bridge_wait_s_option/test-config.yaml
M tests/apps/channel_redirect/test-config.yaml
M tests/apps/confbridge/confbridge_dynamic_menus/test-config.yaml
M tests/apps/confbridge/confbridge_end_marked/test-config.yaml
M tests/apps/confbridge/confbridge_marked/test-config.yaml
M tests/apps/confbridge/confbridge_marked_unmarked/test-config.yaml
M tests/apps/confbridge/confbridge_result/test-config.yaml
M tests/apps/confbridge/confbridge_start_muted/test-config.yaml
M tests/apps/confbridge/confbridge_triple_lindy/test-config.yaml
M tests/apps/confbridge/confbridge_waitmarked_kick/test-config.yaml
M tests/apps/confbridge/confbridge_waitmarked_normal/test-config.yaml
M tests/apps/confbridge/confbridge_waitmarked_only/test-config.yaml
M tests/apps/confbridge/confbridge_waitmarked_single/test-config.yaml
M tests/apps/control_playback/control_forward/test-config.yaml
M tests/apps/control_playback/control_pause/test-config.yaml
M tests/apps/control_playback/control_restart/test-config.yaml
M tests/apps/control_playback/control_reverse/test-config.yaml
M tests/apps/control_playback/control_stop/test-config.yaml
M tests/apps/directed_pickup/pickup/test-config.yaml
M tests/apps/directory/directory_result/test-config.yaml
M tests/apps/disa/nominal/authenticate/test-config.yaml
M tests/apps/disa/nominal/no_authentication/test-config.yaml
M tests/apps/disa/nominal/no_context/test-config.yaml
M tests/apps/disa/off-nominal/bad_auth/test-config.yaml
M tests/apps/disa/off-nominal/invalid_exten/test-config.yaml
M tests/apps/page/page_predial/test-config.yaml
M tests/apps/playback/remote_forward/test-config.yaml
M tests/apps/playback/remote_pause/test-config.yaml
M tests/apps/playback/remote_restart/test-config.yaml
M tests/apps/playback/remote_reverse/test-config.yaml
M tests/apps/playback/remote_stop/test-config.yaml
M tests/apps/say_interrupt/test-config.yaml
M tests/bridge/atxfer_retries/test-config.yaml
M tests/pbx/ast_db/test-config.yaml
43 files changed, 40 insertions(+), 242 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/90/1390/2
-- 
To view, visit https://gerrit.asterisk.org/1390
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e067f7cd80568c9b507ca850771040d5fe2f593
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>