[Asterisk-code-review] app queue: Added reason pause of member (asterisk[master])

Matt Jordan asteriskteam at digium.com
Mon Oct 19 08:22:00 CDT 2015


Matt Jordan has posted comments on this change.

Change subject: app_queue: Added reason pause of member
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Thanks for the contribution!

Since this is a new feature/improvement to app_queue, please do open an issue in issues.asterisk.org. Doing so well let the release notes from the version trace back to the issue tracker, which helps to let everyone know of the new feature/improvement.

You'll also need to add a note about the new field in the CHANGES file.

https://gerrit.asterisk.org/#/c/1447/1/apps/app_queue.c
File apps/app_queue.c:

Line 1047: 					<para>Text description reason of pause if set when was paused.</para>
I'd rephrase this to:

"If set when paused, the reason the queue member was paused."


Line 7081: 	}else{
Nitpick: spaces between the curly braces and the else:

} else {


-- 
To view, visit https://gerrit.asterisk.org/1447
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5db503482f50764c15e2020196c785f59d4a68e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list