[Asterisk-code-review] StatsD: Write Testsuite tests (testsuite[master])

[Tyler Cambron]

Tyler Cambron has posted comments on this change.

Change subject: StatsD: Write Testsuite tests
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/#/c/1392/3/tests/apps/statsd/mockd.py
File tests/apps/statsd/mockd.py:

Line 42: 'stasis.message'
> This may need to be revisited once you get your dialplan application up and
I will keep this in mind and note the behavior when I am able to send statistics out my dialplan application.


Line 63: self.test_object.register_ami_observer(self.ami_connect)
       :         self.test_object.register_stop_observer(self._stop_handler)
> Is there any reason you made one handler public and the other one private? 
I think I originally did it to make pylint happy about enough public methods. This does seem silly, should they both be 'pseudo-private'? Or both public?


-- 
To view, visit https://gerrit.asterisk.org/1392
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93dbeea53cf978461151e9002af2afe1029ce8b
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Tyler Cambron <tcambron at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Tyler Cambron <tcambron at digium.com>
Gerrit-HasComments: Yes