[Asterisk-code-review] chan pjsip: Fix crash on reINVITE before initial INVITE comp... (asterisk[certified/13.1])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: chan_pjsip: Fix crash on reINVITE before initial INVITE completes.
......................................................................


Patch Set 1:

{quote}
What would happen if I:

Sent an INVITE request to Asterisk
Sent a malformed re-INVITE before the INVITE request was confirmed with a 2xx response, where the Call-ID and From tag were identical to the re-INVITE, but no To tag was present in the re-INVITE?
{quote}

An INVITE without a to-tag is not a reINVITE by definition.  I think that the PJSIP library should filter the INVITE "retransmission".  However, I do see your point if PJSIP does not filter the "retransmission" out because we would wind up with the same problem of two threads running the PBX on the channel.

-- 
To view, visit https://gerrit.asterisk.org/1393
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie78201c304a2b13226f3a4ce59908beecc2c68be
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No