[Asterisk-code-review] res/res rtp asterisk.c: Fix incorrect assignment of frame->s... (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: res/res_rtp_asterisk.c: Fix incorrect assignment of frame->subclass.frame_ending
......................................................................


Patch Set 2:

> Since the value of frame->subclass.frame_ending can later be
 > checked in ast_rtp_raw_write, at least in the case when we make a
 > dial between two peers with video when going through multiple local
 > channels, the rtp marker bit always seems to get erased on the
 > outgoing rtp packets. (ast_rtp_raw_write seems to believe
 > frame_ending should be 0 or 1)

Yup, you're correct. Thanks for pointing that out.

This probably should have an ASTERISK issue made up for it as well, as it isn't really just some minor cleanup, but a fix for a legitimate bug. Users who are encountering the issue are more likely to find the ASTERISK issue then this code review. :-)

-- 
To view, visit https://gerrit.asterisk.org/1388
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53bdf5c026041730184a6a809009c028549ce626
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Stefan Engström <stefanen at kth.se>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Stefan Engström <stefanen at kth.se>
Gerrit-HasComments: No