[Asterisk-code-review] res/res rtp asterisk.c: Fix incorrect assignment of frame->s... (asterisk[master])

Matt Jordan asteriskteam at digium.com
Wed Oct 7 06:41:50 CDT 2015


Matt Jordan has posted comments on this change.

Change subject: res/res_rtp_asterisk.c: Fix incorrect assignment of frame->subclass.frame_ending
......................................................................


Patch Set 2:

I certainly don't disagree with this change. However, I'm curious: did this cause an issue in practice some place? After a quick scan through the codebase, I didn't see an instance where a consumer of frame_ending would attempt to check its value explicitly.

-- 
To view, visit https://gerrit.asterisk.org/1388
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53bdf5c026041730184a6a809009c028549ce626
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Stefan Engström <stefanen at kth.se>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list