[Asterisk-code-review] res rtp asterisk: Move "Set role" warning to be debug. (asterisk[11.20])

Joshua Colp asteriskteam at digium.com
Tue Oct 6 12:22:15 CDT 2015


Joshua Colp has submitted this change and it was merged.

Change subject: res_rtp_asterisk: Move "Set role" warning to be debug.
......................................................................


res_rtp_asterisk: Move "Set role" warning to be debug.

In practice the set_role API callback can be invoked even
when no ICE is present on an RTP instance. This can occur
if ICE has not been enabled on it.

ASTERISK-25438 #close

Change-Id: I0e17e4316f0f0d7f095c78c3d4fd73a913b6ba69
(cherry picked from commit fa0985851aba9bc8ca234b66cd47c50e45eae61f)
---
M res/res_rtp_asterisk.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Richard Mudgett: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Verified



diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index ec29905..452f789 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -797,7 +797,7 @@
 		role == AST_RTP_ICE_ROLE_CONTROLLED ? "CONTROLLED" : "CONTROLLING", instance);
 
 	if (!rtp->ice) {
-		ast_log(LOG_WARNING, "Set role failed; no ice instance (%p)\n", instance);
+		ast_debug(3, "Set role failed; no ice instance (%p)\n", instance);
 		return;
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/1387
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0e17e4316f0f0d7f095c78c3d4fd73a913b6ba69
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11.20
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-code-review mailing list