[Asterisk-code-review] chan pjsip: Add Referred-By header to the PJSIP REFER packet. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_pjsip: Add Referred-By header to the PJSIP REFER packet.
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/1149/2//COMMIT_MSG
Commit Message:

Line 9: The AMI DBDelTree command will return Success/Key tree deleted successfully even
I don't think this belongs here.


Line 15: ASTERISK-1149 #close
This isn't the right ASTERISK JIRA issue (is there one for this at all?)


https://gerrit.asterisk.org/#/c/1149/2/channels/chan_pjsip.c
File channels/chan_pjsip.c:

Line 1460: 		ast_sip_add_header(packet, pj_strbuf(&ref_by), pj_strbuf(&session->inv_session->dlg->local.info_str));
You don't need the pj_strbuf ref_by here, you can just use "Referred-By" like above.

As well the local info string is not NULL terminated. You need to use ast_copy_pj_str to copy it into a local buffer in NULL terminated fashion.


-- 
To view, visit https://gerrit.asterisk.org/1149
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d17912ce548667edf53cb549e88a25475eda245
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes