[Asterisk-code-review] bridges/bridge t38: Add a bridging module for managing T.38 ... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: bridges/bridge_t38: Add a bridging module for managing T.38 state
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.asterisk.org/#/c/1725/3//COMMIT_MSG
Commit Message:

Line 9: When 4875e5ac32 was merged, it fixed several issues with a direct media bridge
It would be a good idea to reference the issue associated with the git hash (ASTERISK-25582).  This patch is a follow-up or fix of a fix to the original issue.


https://gerrit.asterisk.org/#/c/1725/3/bridges/bridge_t38.c
File bridges/bridge_t38.c:

Line 160: 	c_state = bridge_channel == state->bc0 ? &(state->c0_state) : &(state->c1_state);
        : 	other_state = bridge_channel == state->bc0 ? &(state->c1_state) : &(state->c0_state);
The parentheses aren't necessary.


Line 171: 				case AST_T38_REQUEST_NEGOTIATE:
        : 					*c_state = T38_STATE_NEGOTIATING;
        : 					*other_state = T38_STATE_NEGOTIATING;
        : 					break;
        : 				case AST_T38_NEGOTIATED:
        : 					*c_state = T38_STATE_NEGOTIATED;
        : 					break;
        : 				case AST_T38_TERMINATED:
        : 				case AST_T38_REQUEST_TERMINATE:
        : 				case AST_T38_REFUSED:
        : 					*c_state = T38_STATE_REJECTED;
        : 					break;
        : 				case AST_T38_REQUEST_PARMS:
        : 				default:
        : 					/* No state change */
        : 					break;
indented one level too far


-- 
To view, visit https://gerrit.asterisk.org/1725
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5b0bb478eb01c4607c9f4a7fc17c7957d260ea0
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes