[Asterisk-code-review] Add a negative DNS cache (asterisk[13])

Corey Farrell asteriskteam at digium.com
Mon Nov 30 10:34:11 CST 2015


Corey Farrell has posted comments on this change.

Change subject: Add a negative DNS cache
......................................................................


Patch Set 2: Code-Review-1

If you install dnsmasq or similar to localhost and use that in /etc/resolv.conf, wouldn't you get NX caching without this commit?  In that case it seems like caching by Asterisk itself would make the NX to last longer than it should.  I would be looking to disable this functionality in Asterisk, leave DNS caching logic to a daemon built for that purpose.

I'd be very happy with an ABI compatible compile-time option to disable this.  This might be preferable to a run-time option since it would erase all overhead of the ao2 lookups.

-- 
To view, visit https://gerrit.asterisk.org/1709
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb9f8c7ec15eedd4701461bf865e8036a5732388
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list