[Asterisk-code-review] Test DNS negative cache entries (testsuite[master])

Joshua Colp asteriskteam at digium.com
Mon Nov 30 05:52:21 CST 2015


Joshua Colp has posted comments on this change.

Change subject: Test DNS negative cache entries
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1711/1/tests/dns_cache/dns_test.py
File tests/dns_cache/dns_test.py:

Line 54:                     reactor.callLater(65, __originate_call)
Instead of a "should be 60 secs" which at 65 seconds later should work, can we use an event to guarantee things?


-- 
To view, visit https://gerrit.asterisk.org/1711
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01d0dd9dfa8d565f1415f56375f2fa7976e4309f
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list