[Asterisk-code-review] Add a negative DNS cache (asterisk[master])

Joshua Colp asteriskteam at digium.com
Mon Nov 30 05:50:18 CST 2015


Joshua Colp has posted comments on this change.

Change subject: Add a negative DNS cache
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1710/2/main/dns_core.c
File main/dns_core.c:

Line 539: 			ast_dns_cache_add_or_update(query->name);
I've not a huge fan of overriding the TTL as provided in the DNS resolution result, it may be lower than what is configured telling us to try back sooner.


-- 
To view, visit https://gerrit.asterisk.org/1710
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb9f8c7ec15eedd4701461bf865e8036a5732388
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list