[Asterisk-code-review] chan sip: Support parsing of Q.850 reason header in SIP BYE ... (asterisk[master])

[Christof Lauber]

Christof Lauber has posted comments on this change.

Change subject: chan_sip: Support parsing of Q.850 reason header in SIP BYE and CANCEL requests.
......................................................................


Patch Set 1:

(1 comment)

Squashed all changes into initial change 1620

https://gerrit.asterisk.org/#/c/1643/1/channels/chan_sip.c
File channels/chan_sip.c:

Line 16132
> I'm not sure removing this line is a good thing.
Hi Richard, 
Matt pointed out that this could be problematic since we do reset hangup cause even if we don't know if there is a valid Q.850 Reason. I would suggest to re-add initialzation for responses only in  handle_response():

if (owner) {
		ast_channel_hangupcause_set(owner, 0);
		if (use_reason_header(p, req)) {
			/* Use the SIP cause */
			ast_channel_hangupcause_set(owner, hangup_sip2cause(resp));
		}
	}


-- 
To view, visit https://gerrit.asterisk.org/1643
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0389134dc53879387f05cb86a9340559bdb122db
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Christof Lauber <christof.lauber at annax.ch>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Christof Lauber <christof.lauber at annax.ch>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes