[Asterisk-code-review] lib/python/asterisk/pcap: Fix SDPPacket regression introduce... (testsuite[master])

Matt Jordan asteriskteam at digium.com
Wed Nov 25 14:20:21 CST 2015


Matt Jordan has uploaded a new change for review.

  https://gerrit.asterisk.org/1718

Change subject: lib/python/asterisk/pcap: Fix SDPPacket regression introduced in 43061c6038
......................................................................

lib/python/asterisk/pcap: Fix SDPPacket regression introduced in 43061c6038

A type was introduced in 43061c6038 that only affected SDPPackets generated as
a result of sniffed VoIP traffic. A parameter, ascii_packet, was instead being
referenced as ascii_pack. This patch corrects the spelling of the parameter.

Note that the PJSIP direct media tests were properly able to sniff the traffic
once this was corrected.

Change-Id: I4027736e8cb02b454e0e7e1f11bb876d12d175ac
---
M lib/python/asterisk/pcap.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/18/1718/1

diff --git a/lib/python/asterisk/pcap.py b/lib/python/asterisk/pcap.py
index 1523e9d..91031f5 100644
--- a/lib/python/asterisk/pcap.py
+++ b/lib/python/asterisk/pcap.py
@@ -436,7 +436,7 @@
 
         body_type, _, _ = content_type.partition(';')
         if (body_type == 'application/sdp'):
-            return SDPPacket(ascii_pack, raw_packet)
+            return SDPPacket(ascii_packet, raw_packet)
         elif (body_type == 'multipart/related'):
             return MultipartPacket(content_type, ascii_packet, raw_packet)
         elif (body_type == 'application/rlmi+xml'):

-- 
To view, visit https://gerrit.asterisk.org/1718
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4027736e8cb02b454e0e7e1f11bb876d12d175ac
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>



More information about the asterisk-code-review mailing list