[Asterisk-code-review] main: Slight refactor of main. Improve color situation. (asterisk[11])

Corey Farrell asteriskteam at digium.com
Wed Nov 25 09:11:42 CST 2015


Corey Farrell has posted comments on this change.

Change subject: main: Slight refactor of main. Improve color situation.
......................................................................


Patch Set 5:

(4 comments)

Just need a few line-feeds then this looks good to me.

https://gerrit.asterisk.org/#/c/1698/5/main/asterisk.c
File main/asterisk.c:

Line 3055: 	if (!ast_strlen_zero(home)) {
Can we get a line-feed after the variable declares?


Line 3065: 	if (!ast_strlen_zero(home)) {
Here too.


Line 4060: 	/* This needs to remain as high up in the initial start up as possible.
Here too.


Line 4406: 		if (gethostname(hostname, sizeof(hostname) - 1)) {
Here too.


-- 
To view, visit https://gerrit.asterisk.org/1698
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib641a0964c59ef9fe6f59efa8ccb481a9580c52f
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list