[Asterisk-code-review] pjsip/sdp offer answer/attribute passthrough: Move files for... (testsuite[master])

Anonymous Coward asteriskteam at digium.com
Tue Nov 24 08:31:35 CST 2015


Anonymous Coward #1000019 has submitted this change and it was merged.

Change subject: pjsip/sdp_offer_answer/attribute_passthrough: Move files for new formats
......................................................................


pjsip/sdp_offer_answer/attribute_passthrough: Move files for new formats

The existing attribute_passthrough test attempts to test all attribute format
modules in one shot. While that's nice, new format attribute modules can't be
easily added in that scheme, as the module may not exist for certain versions
of Asterisk. This patch merely reorganizes the tests here by moving the
existing attribute_passthrough test and renaming it as 'speex_h263_h264' -
as those are the attribute modules tested - and changing the
attribute_passthrough folder to be a directory of tests.

Change-Id: I35bb61177d5e0f5be84c32fad9d9fe1e78485707
---
R tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/extensions.conf
R tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf
R tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/run-test
R tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_h263.xml
R tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_h264.xml
R tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_speex.xml
R tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h263.xml
R tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml
R tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_speex.xml
R tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/test-config.yaml
A tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/tests.yaml
M tests/channels/pjsip/sdp_offer_answer/tests.yaml
12 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/configs/ast1/extensions.conf b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/extensions.conf
similarity index 100%
rename from tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/configs/ast1/extensions.conf
rename to tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/extensions.conf
diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/configs/ast1/pjsip.conf b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf
similarity index 100%
rename from tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/configs/ast1/pjsip.conf
rename to tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf
diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/run-test b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/run-test
similarity index 100%
rename from tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/run-test
rename to tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/run-test
diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_A_h263.xml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_h263.xml
similarity index 100%
rename from tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_A_h263.xml
rename to tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_h263.xml
diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_A_h264.xml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_h264.xml
similarity index 100%
rename from tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_A_h264.xml
rename to tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_h264.xml
diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_A_speex.xml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_speex.xml
similarity index 100%
rename from tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_A_speex.xml
rename to tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_speex.xml
diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_B_h263.xml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h263.xml
similarity index 100%
rename from tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_B_h263.xml
rename to tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h263.xml
diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_B_h264.xml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml
similarity index 100%
rename from tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_B_h264.xml
rename to tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml
diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_B_speex.xml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_speex.xml
similarity index 100%
rename from tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/sipp/phone_B_speex.xml
rename to tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_speex.xml
diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/test-config.yaml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/test-config.yaml
similarity index 100%
rename from tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/test-config.yaml
rename to tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/test-config.yaml
diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/tests.yaml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/tests.yaml
new file mode 100644
index 0000000..cdf6a6d
--- /dev/null
+++ b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/tests.yaml
@@ -0,0 +1,3 @@
+# Enter tests here in the order they should be considered for execution:
+tests:
+    - test: 'speex_h263_h264'
diff --git a/tests/channels/pjsip/sdp_offer_answer/tests.yaml b/tests/channels/pjsip/sdp_offer_answer/tests.yaml
index 9abb817..b0e0de9 100644
--- a/tests/channels/pjsip/sdp_offer_answer/tests.yaml
+++ b/tests/channels/pjsip/sdp_offer_answer/tests.yaml
@@ -1,4 +1,4 @@
 # Enter tests here in the order they should be considered for execution:
 tests:
     - dir: 'incoming'
-    - test: 'attribute_passthrough'
+    - dir: 'attribute_passthrough'

-- 
To view, visit https://gerrit.asterisk.org/1702
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35bb61177d5e0f5be84c32fad9d9fe1e78485707
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list