[Asterisk-code-review] res format attr vp8: In SDP, forward max-fr and max-fs for v... (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: res_format_attr_vp8: In SDP, forward max-fr and max-fs for video-codec VP8.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Really nice job!

I'm giving this a -1 only because new modules should be listed in the CHANGES file along with the version that they were introduced into the project. In this case, that should be 13.7.0.

https://gerrit.asterisk.org/#/c/1676/1/res/res_format_attr_vp8.c
File res/res_format_attr_vp8.c:

Line 115: 		if (added) {
        : 			ast_str_append(str, 0, ";");
        : 		} else if (0 < ast_str_append(str, 0, "a=fmtp:%u ", payload)) {
        : 			added = 1;
        : 		}
Nitpick: technically, added can never be non-zero here. This could instead be written:

if (0 < ast_str_append(str ...)) {
    added = 1;
}

Clearly, every attribute after the first does need to check added.


-- 
To view, visit https://gerrit.asterisk.org/1676
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae00071b4ff1ae76f24995aeac4d00284fd14f91
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes