[Asterisk-code-review] res/res endpoint stats: Add module to emit endpoint StatsD s... (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res/res_endpoint_stats: Add module to emit endpoint StatsD statistics
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/1692/4/res/res_endpoint_stats.c
File res/res_endpoint_stats.c:

Line 65: 		ast_statsd_log_string("endpoints.count", AST_STATSD_GUAGE, "+1", 1.0);
OMG, is our #define actually misspelled?

I corrected your commit message because I thought you had just made a mistake, but it turns out the mistake goes deeper.


-- 
To view, visit https://gerrit.asterisk.org/1692
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7e1333c5aeda8d136850b30c2101c0ee1c97305
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes