[Asterisk-code-review] chan sip: option 'notifyringing' doc fix and addition of 'no... (asterisk[master])

Matt Jordan asteriskteam at digium.com
Mon Nov 23 14:44:44 CST 2015


Matt Jordan has posted comments on this change.

Change subject: chan_sip: option 'notifyringing' doc fix and addition of 'notifyringingprio'
......................................................................


Patch Set 2:

> Maybe notifywhileinuse ? Ringing is the only indication that can be
 > sent during INUSE.

Except that notify would make me think NOTIFY, which isn't correct here. :-\

(Naming is hard)

-- 
To view, visit https://gerrit.asterisk.org/1649
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88f7036ee084bb3f43b74f15612695c6708f74aa
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Ward van Wanrooij <ward at ward.nu>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Ward van Wanrooij <ward at ward.nu>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list