[Asterisk-code-review] channels/chan sip: 180 Ringing not sent after 183 Session Pr... (asterisk[master])

[Morten Tryfoss]

Morten Tryfoss has uploaded a new change for review.

  https://gerrit.asterisk.org/1695

Change subject: channels/chan_sip: 180 Ringing not sent after 183 Session Progress
......................................................................

channels/chan_sip: 180 Ringing not sent after 183 Session Progress

We should always forward 180 Ringing when early media is active, except when
progressinband=yes.

ASTERISK-25568

Change-Id: I498fed853128831b80536f8818cd7b60e641f39c
---
M channels/chan_sip.c
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/95/1695/1

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 158dc7b..9e88602 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -7655,6 +7655,11 @@
 					break;
 			} else {
 				/* Well, if it's not reasonable, just send in-band */
+				if (ast_test_flag(&p->flags[0], SIP_PROG_INBAND) != SIP_PROG_INBAND_YES && !ast_test_flag(&p->flags[0], SIP_RINGING)) {
+					transmit_provisional_response(p, "180 Ringing", &p->initreq, 0);
+					ast_set_flag(&p->flags[0], SIP_RINGING);
+					break;
+				}
 			}
 		}
 		res = -1;

-- 
To view, visit https://gerrit.asterisk.org/1695
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I498fed853128831b80536f8818cd7b60e641f39c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Morten Tryfoss <morten at tryfoss.no>