[Asterisk-code-review] tests/rest api/asterisk/logging: Don't stop test when iterat... (testsuite[master])

Anonymous Coward asteriskteam at digium.com
Sat Nov 21 17:59:28 CST 2015


Anonymous Coward #1000019 has submitted this change and it was merged.

Change subject: tests/rest_api/asterisk/logging: Don't stop test when iteration ends.
......................................................................


tests/rest_api/asterisk/logging: Don't stop test when iteration ends.

Two of the ARI logging tests are written to expect a StasisEnd to arrive
to do logging checks and stop the test. There was a race condition
where the iteration may end tearing everything down prematurely. The
tests will now be stopped by the StasisEnd arriving instead.

ASTERISK-25319 #close

Change-Id: I6231a6da81ddc1a4fd45a28bb6f11a2e491b443c
---
M tests/rest_api/asterisk/logging/add_log/test-config.yaml
M tests/rest_api/asterisk/logging/rotate_log/test-config.yaml
2 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Anonymous Coward #1000019: Verified
  Matt Jordan: Looks good to me, approved



diff --git a/tests/rest_api/asterisk/logging/add_log/test-config.yaml b/tests/rest_api/asterisk/logging/add_log/test-config.yaml
index cf6ac7b..2780f39 100644
--- a/tests/rest_api/asterisk/logging/add_log/test-config.yaml
+++ b/tests/rest_api/asterisk/logging/add_log/test-config.yaml
@@ -14,6 +14,9 @@
             config-section: ari-config
             typename: pluggable_modules.EventActionModule
 
+test-object-config:
+    stop-on-end: False
+
 ari-config:
     -
         ari-events:
diff --git a/tests/rest_api/asterisk/logging/rotate_log/test-config.yaml b/tests/rest_api/asterisk/logging/rotate_log/test-config.yaml
index b0c1c9a..70a1ce8 100644
--- a/tests/rest_api/asterisk/logging/rotate_log/test-config.yaml
+++ b/tests/rest_api/asterisk/logging/rotate_log/test-config.yaml
@@ -14,6 +14,9 @@
             config-section: ari-config
             typename: pluggable_modules.EventActionModule
 
+test-object-config:
+    stop-on-end: False
+
 ari-config:
     -
         ari-events:

-- 
To view, visit https://gerrit.asterisk.org/1680
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6231a6da81ddc1a4fd45a28bb6f11a2e491b443c
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>



More information about the asterisk-code-review mailing list