[Asterisk-code-review] chan pjsip: Handle T.38 faxes with direct media bridges (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_pjsip: Handle T.38 faxes with direct media bridges
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1668/2//COMMIT_MSG
Commit Message:

Line 43: Fixup
       : 
       : Change-Id: Iabd6aa578e633d16e6b9f342091264e4324a79eb
Should this... be here?


https://gerrit.asterisk.org/#/c/1668/2/res/res_pjsip_t38.c
File res/res_pjsip_t38.c:

Line 575: 	RAII_VAR(struct ast_datastore *, datastore, ast_sip_session_get_datastore(session, "t38"), ao2_cleanup);
        : 	RAII_VAR(struct ast_sip_session_media *, session_media, ao2_find(session->media, "image", OBJ_KEY), ao2_cleanup);
It may match the rest of things, but I think we should try to reduce how much more gratuitous usage we introduce.


-- 
To view, visit https://gerrit.asterisk.org/1668
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabd6aa578e633d16e6b9f342091264e4324a79eb
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes