[Asterisk-code-review] chan sip: option 'notifyringing' doc fix and addition of 'no... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_sip: option 'notifyringing' doc fix and addition of 'notifyringingprio'
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1649/2/configs/samples/sip.conf.sample
File configs/samples/sip.conf.sample:

Line 698: ;notifyringingprio = no         ; Control whether subscriptions already INUSE get sent
I don't think "notifyringingprio" is a good name for this option. It took me a bit to determine that you meant priority. Even then I'm not sure it's great.

notifyringingwhileinuse maybe? That clearly states what the option is, although it is a bit long.


-- 
To view, visit https://gerrit.asterisk.org/1649
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88f7036ee084bb3f43b74f15612695c6708f74aa
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Ward van Wanrooij <ward at ward.nu>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes