[Asterisk-code-review] tests/apps/statsd: Move mockd library to /lib/python/ (testsuite[master])

[Anonymous Coward]

Anonymous Coward #1000019 has submitted this change and it was merged.

Change subject: tests/apps/statsd: Move mockd library to /lib/python/
......................................................................


tests/apps/statsd: Move mockd library to /lib/python/

Since the mock StatsD pluggable module will be useful for tests outside of the
apps directory, this patch moves it to lib/python. It also removes the Python
path manipulation directives from the existing statsd application tests, as
the Python path used by test-runner will already find the mockd library in the
lib/python path.

Change-Id: Ic1b678c1b43217cc5d3a415b3c86e2369e04772c
---
R lib/python/mockd.py
M tests/apps/statsd/nominal/test-config.yaml
M tests/apps/statsd/off-nominal/empty_params/test-config.yaml
M tests/apps/statsd/off-nominal/invalid_metric/test-config.yaml
M tests/apps/statsd/off-nominal/invalid_sample_rate/test-config.yaml
M tests/apps/statsd/off-nominal/invalid_value/test-config.yaml
M tests/apps/statsd/off-nominal/invalid_variable/test-config.yaml
M tests/apps/statsd/off-nominal/no_metric/test-config.yaml
M tests/apps/statsd/off-nominal/no_value/test-config.yaml
9 files changed, 0 insertions(+), 16 deletions(-)

Approvals:
  Anonymous Coward #1000019: Verified
  Matt Jordan: Looks good to me, approved
  Joshua Colp: Looks good to me, but someone else must approve



diff --git a/tests/apps/statsd/mockd.py b/lib/python/mockd.py
similarity index 100%
rename from tests/apps/statsd/mockd.py
rename to lib/python/mockd.py
diff --git a/tests/apps/statsd/nominal/test-config.yaml b/tests/apps/statsd/nominal/test-config.yaml
index 1103d9f..602c26e 100644
--- a/tests/apps/statsd/nominal/test-config.yaml
+++ b/tests/apps/statsd/nominal/test-config.yaml
@@ -7,8 +7,6 @@
         to StatsD through the StatsD Dialplan Application.
 
 test-modules:
-    add-test-to-search-path: 'True'
-    add-relative-to-search-path: ['..']
     test-object:
         config-section: 'test-object-config'
         typename: 'test_case.TestCaseModule'
diff --git a/tests/apps/statsd/off-nominal/empty_params/test-config.yaml b/tests/apps/statsd/off-nominal/empty_params/test-config.yaml
index 5ce4f54..44ee2b0 100644
--- a/tests/apps/statsd/off-nominal/empty_params/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/empty_params/test-config.yaml
@@ -6,8 +6,6 @@
         appropriately when no parameters are given.
 
 test-modules:
-    add-test-to-search-path: 'True'
-    add-relative-to-search-path: ['../..']
     test-object:
         config-section: 'test-object-config'
         typename: 'test_case.TestCaseModule'
diff --git a/tests/apps/statsd/off-nominal/invalid_metric/test-config.yaml b/tests/apps/statsd/off-nominal/invalid_metric/test-config.yaml
index 748b5f4..a1870b3 100644
--- a/tests/apps/statsd/off-nominal/invalid_metric/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/invalid_metric/test-config.yaml
@@ -6,8 +6,6 @@
         appropriately when an invalid metric type is given.
 
 test-modules:
-    add-test-to-search-path: 'True'
-    add-relative-to-search-path: ['../..']
     test-object:
         config-section: 'test-object-config'
         typename: 'test_case.TestCaseModule'
diff --git a/tests/apps/statsd/off-nominal/invalid_sample_rate/test-config.yaml b/tests/apps/statsd/off-nominal/invalid_sample_rate/test-config.yaml
index 43d274f..b65a072 100644
--- a/tests/apps/statsd/off-nominal/invalid_sample_rate/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/invalid_sample_rate/test-config.yaml
@@ -6,8 +6,6 @@
         appropriately when a variable name is not given.
 
 test-modules:
-    add-test-to-search-path: 'True'
-    add-relative-to-search-path: ['../..']
     test-object:
         config-section: 'test-object-config'
         typename: 'test_case.TestCaseModule'
diff --git a/tests/apps/statsd/off-nominal/invalid_value/test-config.yaml b/tests/apps/statsd/off-nominal/invalid_value/test-config.yaml
index cc7109e..a6a088f 100644
--- a/tests/apps/statsd/off-nominal/invalid_value/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/invalid_value/test-config.yaml
@@ -6,8 +6,6 @@
         appropriately when an invalid value is given.
 
 test-modules:
-    add-test-to-search-path: 'True'
-    add-relative-to-search-path: ['../..']
     test-object:
         config-section: 'test-object-config'
         typename: 'test_case.TestCaseModule'
diff --git a/tests/apps/statsd/off-nominal/invalid_variable/test-config.yaml b/tests/apps/statsd/off-nominal/invalid_variable/test-config.yaml
index d9da725..54a031c 100644
--- a/tests/apps/statsd/off-nominal/invalid_variable/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/invalid_variable/test-config.yaml
@@ -6,8 +6,6 @@
         appropriately when an invalid variable name is given.
 
 test-modules:
-    add-test-to-search-path: 'True'
-    add-relative-to-search-path: ['../..']
     test-object:
         config-section: 'test-object-config'
         typename: 'test_case.TestCaseModule'
diff --git a/tests/apps/statsd/off-nominal/no_metric/test-config.yaml b/tests/apps/statsd/off-nominal/no_metric/test-config.yaml
index e9dc0c4..4b75ea4 100644
--- a/tests/apps/statsd/off-nominal/no_metric/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/no_metric/test-config.yaml
@@ -6,8 +6,6 @@
         appropriately when a metric type is not given.
 
 test-modules:
-    add-test-to-search-path: 'True'
-    add-relative-to-search-path: ['../..']
     test-object:
         config-section: 'test-object-config'
         typename: 'test_case.TestCaseModule'
diff --git a/tests/apps/statsd/off-nominal/no_value/test-config.yaml b/tests/apps/statsd/off-nominal/no_value/test-config.yaml
index 2960358..8fbafa1 100644
--- a/tests/apps/statsd/off-nominal/no_value/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/no_value/test-config.yaml
@@ -6,8 +6,6 @@
         appropriately when a value is not given.
 
 test-modules:
-    add-test-to-search-path: 'True'
-    add-relative-to-search-path: ['../..']
     test-object:
         config-section: 'test-object-config'
         typename: 'test_case.TestCaseModule'

-- 
To view, visit https://gerrit.asterisk.org/1656
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1b678c1b43217cc5d3a415b3c86e2369e04772c
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>