[Asterisk-code-review] app bridgeaddchan: ability to barge into existing call (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_bridgeaddchan: ability to barge into existing call
......................................................................


Patch Set 10:

(3 comments)

Looking good.

https://gerrit.asterisk.org/#/c/1631/10/CHANGES
File CHANGES:

Line 21:    to an existing bridge containing the named bridgechannel prefix.
Missed this one:
...named channel prefix...


https://gerrit.asterisk.org/#/c/1631/10/apps/app_bridgeaddchan.c
File apps/app_bridgeaddchan.c:

Line 48: 			<parameter name="name">
       :                                 <para>Name of the channel in an existing bridge
       :                                 </para>
       :                         </parameter>
Inconsistent leading whitespace.


Line 107: 	if (ast_bridge_join(bridge, chan, NULL, &chan_features, NULL, 0)) {
To eliminate some duplicate code from above this could be:

if (ast_bridge_features_init()
    || ast_bridge_join()) {
    ...
}


-- 
To view, visit https://gerrit.asterisk.org/1631
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8eb5096a02168dcc8d7aeea416ef36ba4ed10540
Gerrit-PatchSet: 10
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alec Davis <sivad.a at paradise.net.nz>
Gerrit-Reviewer: Alec Davis <sivad.a at paradise.net.nz>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes