[Asterisk-code-review] res pjsip outbound registration.c: Fix 423 response handling. (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_pjsip_outbound_registration.c: Fix 423 response handling.
......................................................................


Patch Set 1: Code-Review-1

There are two problems I have with this approach

1) The more minor problem is that this is going to mess up certain assumptions, most obviously messing up the auth_loop outbound registration test.

2) The more major problem is that this doesn't necessarily fix the real underlying problem. The problem here is that we are thinking that we are receiving a 401 on a transaction where we originated the REGISTER attempt. In reality, we haven't actually attempted authentication because PJSIP handled the 423 response on its own.

I think the real fix here is to instead save the CSeq or branch of the outbound REGISTER that we send with authentication. If we receive another 401 and the incoming CSeq or branch does not match what we saved, then we're receiving a response to a different transaction, and we should attempt auth again. If the CSeq or branch does match, then we clearly are stuck in an auth loop and should break it.

-- 
To view, visit https://gerrit.asterisk.org/1644
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81b4bd36d1be095bab606e34b8b44e6302971b09
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No