[Asterisk-code-review] translate: Provide translation modules the result of SDP neg... (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Tue Nov 17 10:59:39 CST 2015


Kevin Harwell has posted comments on this change.

Change subject: translate: Provide translation modules the result of SDP negotiation.
......................................................................


Patch Set 4:

I probably lean toward 'A' myself as it seems to be the most conservative and least likely to break any current functionality.

However, I am not opposed to 'B', but what happens if a format was already set? You'd retain the current one, but this would then potentially be missing the information you need, correct?

-- 
To view, visit https://gerrit.asterisk.org/1598
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6878a989b50573298dab115d3371ea369e1a718
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list