[Asterisk-code-review] translate: Provide translation modules the result of SDP neg... (asterisk[master])

Alexander Traud asteriskteam at digium.com
Tue Nov 17 08:53:32 CST 2015


Alexander Traud has posted comments on this change.

Change subject: translate: Provide translation modules the result of SDP negotiation.
......................................................................


Patch Set 4:

If I understand correctly, we have three approaches then:
A) re-introduce explicit_dst; because of ABI change just for master 
B) attach the joint format to the frame, after newpvt was called and still NULL; for branch 13 and master
C) attach the joint format to the frame

Alternative C – proposed here – is not available because that changes the API. Once again: Who is using the API that way? Please, explain and vote for one approach within the issue report ASTERISK-25545. Or do we have a consensus on the approach already?

-- 
To view, visit https://gerrit.asterisk.org/1598
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6878a989b50573298dab115d3371ea369e1a718
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list