[Asterisk-code-review] res/res pjsip: Fix off nominal crash with requests that fail... (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Mon Nov 16 14:31:42 CST 2015


Richard Mudgett has posted comments on this change.

Change subject: res/res_pjsip: Fix off nominal crash with requests that fail and have a timer
......................................................................


Patch Set 1:

On the subject of not handling the pj_timer_heap_cancel_if_active() return value.  There is a call to pj_timer_heap_cancel_if_active() in endpt_send_request() that seems to be a NoOp since the timer was just created/initialized and then we go and cancel it.

-- 
To view, visit https://gerrit.asterisk.org/1639
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21332343a1a019c1117076f9bf2df27be2850102
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list