[Asterisk-code-review] res/res pjsip: Fix off nominal crash with requests that fail... (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: res/res_pjsip: Fix off nominal crash with requests that fail and have a timer
......................................................................


Patch Set 1:

For reviewers:

The reference on the request wrapper can be seen below:
0x7fff80003e58,+1,17884,res_pjsip.c,3105,endpt_send_request,**constructor**,
0x7fff80003e58,+1,17884,res_pjsip.c,3139,endpt_send_request,1,
0x7fff80003e58,+1,17884,res_pjsip.c,3151,endpt_send_request,2,
0x7fff80003e58,-1,17884,res_pjsip.c,3025,endpt_send_request_cb,3,
0x7fff80003e58,-1,17884,res_pjsip.c,3046,endpt_send_request_cb,2,
0x7fff80003e58,-1,17884,res_pjsip.c,3160,endpt_send_request,**destructor**,

The crash occurs on the ao2_unlock of the object on line 3185 of res_pjsip, due to the object being destroyed. Note that we've already deref-d the reference associated with the timer here:

0x7fff80003e58,-1,17884,res_pjsip.c,3025,endpt_send_request_cb,3,

And then we do it again here:

1,17884,res_pjsip.c,3160,endpt_send_request,**destructor**,

-- 
To view, visit https://gerrit.asterisk.org/1639
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21332343a1a019c1117076f9bf2df27be2850102
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No