[Asterisk-code-review] Testsuite: Corrected Order of Operations for RLSTest Ctor (testsuite[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: Testsuite: Corrected Order of Operations for RLSTest Ctor
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1635/1/tests/channels/pjsip/subscriptions/rls/rls_test.py
File tests/channels/pjsip/subscriptions/rls/rls_test.py:

Line 112:        token_msg = (
        :             "Test execution was interrupted before all NOTIFY "
        :             "packets were accounted for.")
        :         self.token = self.test_object.create_fail_token(token_msg)
        : 
        :         self.ami = None
        :         self.packets_idx = 0
        :         self.list_name = module_config["list-name"]
        :         self.log_packets = module_config.get("log-packets", False)
        :         self.packets = module_config["packets"]
        : 
        :         self.stop_test_after_notifys = \
        :             module_config.get("stop-test-after-notifys", True)
        : 
        :         self.test_object.register_ami_observer(self.on_ami_connect)
        :         self.add_callback("SIP", self.multipart_handler)
        : 
        :         if self.check_prerequisites():
        :             self.test_object.register_scenario_started_observer(
        :                 self.on_scenario_started)
I don't think I understand why this change was necessary. In your prior patch, what now references self.token that didn't before? And why does it need to do so?

Note: I couldn't understand this from the commit message. This patch may just need a slightly clearer description of why this change is necessary in the commit message.


-- 
To view, visit https://gerrit.asterisk.org/1635
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c2e41d3ae56594f426cc0b23fc5ca808b856ddb
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes