[Asterisk-code-review] Confbridge: Add a user timeout option (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Confbridge: Add a user timeout option
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

CHANGES/UPDATE.txt should get a note added advertising the new confbridge option.

Also should add the new option description to confbridge.conf.sample.

https://gerrit.asterisk.org/#/c/1627/1/apps/app_confbridge.c
File apps/app_confbridge.c:

Line 1553: 			AST_CAUSE_NORMAL_CLEARING);
If you pass 0 instead of AST_CAUSE_NORMAL_CLEARING you won't need to include causes.h.  The cause will be set to AST_CAUSE_NORMAL_CLEARING if a cause is not already set on the channel.


Line 1794: 			AST_BRIDGE_HOOK_TIMER_OPTION_MEDIA,
Pass 0 here.  The hook does not affect media so AST_CONTROL_SRCUPDATE does not need to be sent while the hook executes.


https://gerrit.asterisk.org/#/c/1627/1/apps/confbridge/conf_config_parser.c
File apps/confbridge/conf_config_parser.c:

Line 231: 					<synopsis>Kick the user out of the conference after this many seconds</synopsis>
Mention that 0 disables the timeout.


Line 2147: 	aco_option_register(&cfg_info, "timeout", ACO_EXACT, user_types, "0", OPT_UINT_T, PARSE_DEFAULT, FLDSET(struct user_profile, timeout), 0);
The example you used seems to have been an exception case to use the PARSE_DEFAULT flag.  How about using this as the example:

aco_option_register(&cfg_info, "max_members", ACO_EXACT, bridge_types, "0", OPT_UINT_T, 0, FLDSET(struct bridge_profile, max_members));


-- 
To view, visit https://gerrit.asterisk.org/1627
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2996b6c5e16a3dda27595f8352abad0bda9c2d98
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes