[Asterisk-code-review] chan sip: Support parsing of Q.850 reason header in SIP BYE ... (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: chan_sip: Support parsing of Q.850 reason header in SIP BYE and CANCEL requests.
......................................................................


Patch Set 1: Code-Review-1

As zuul reported, this patch breaks the build:

2015-11-13 08:18:21 gcc  -o chan_rtp.so -pthread    -ftest-coverage -fprofile-arcs  -shared -Wl,--version-script,chan_rtp.exports,--warn-common  chan_rtp.o  
2015-11-13 08:18:21 gcc -o /dev/null -c chan_sip.i -pthread -I/srv/jenkins/workspace/check-asterisk/asterisk/include    -I/usr/include/libxml2 -pipe -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations   -g3 -Werror -Wunused -Wdeclaration-after-statement  -Wundef -Wmissing-format-attribute -Wformat=2  -O0  -march=native -fPIC -DAST_MODULE=\"chan_sip\" -DAST_MODULE_SELF_SYM=__internal_chan_sip_self    -O3
2015-11-13 08:18:21 cc1: warnings being treated as errors
2015-11-13 08:18:21 chan_sip.c: In function 'parse_reason_header':
2015-11-13 08:18:21 chan_sip.c:16128: error: ISO C90 forbids mixed declarations and code
2015-11-13 08:18:22 make[1]: *** [chan_sip.o] Error 1

When developing, please configure Asterisk into dev-mode, as this will help you catch compiler warnings:

./configure --enable-dev-mode

-- 
To view, visit https://gerrit.asterisk.org/1620
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeed95a9c7c7fa86a67d0c512f3e75f28f86e66c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Christof Lauber <christof.lauber at annax.ch>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No