[Asterisk-code-review] translate: Provide translation modules the result of SDP neg... (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: translate: Provide translation modules the result of SDP negotiation.
......................................................................


Patch Set 4:

Just as additional information: *Till* Asterisk 12, the struct ast_trans_pvt included the member "explicit_dst". That format was the joint format, actually – and responsible for this. I hate to break the ABI, but if you are more concerned about the contract/API, I could undo https://reviewboard.asterisk.org/r/3775/ and reintroduce this "explicit_dst" member. What about that approach?

Nevertheless, I prefer the current change because I am not aware of anyone using the mentioned corner case (assigning a format in newpvt without unreferencing the member variable).

-- 
To view, visit https://gerrit.asterisk.org/1598
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6878a989b50573298dab115d3371ea369e1a718
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: No