[Asterisk-code-review] res pjsip: Deny requests when threadpool queue is backed up. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip: Deny requests when threadpool queue is backed up.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1607/2/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:

Line 285: 	if (ast_sip_threadpool_queue_size() > SIP_MAX_QUEUE) {
        : 		/* When the threadpool is backed up this much, there is a good chance that we have encountered
        : 		 * some sort of terrible condition and don't need to be adding more work to the threadpool.
        : 		 * It's in our best interest to send back a 503 response and be done with it.
        : 		 */
        : 		pjsip_endpt_respond_stateless(ast_sip_get_pjsip_endpoint(), rdata, 503, NULL, NULL, NULL);
We would be sending a response to a response back here.  We should send a response if it is a request and ignore the received response if it is a response.


-- 
To view, visit https://gerrit.asterisk.org/1607
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e736d48a2ba79fd1f8056c0dcd330e38e6a3816
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes