[Asterisk-code-review] threadpool: Handle worker thread transitioning to dead when ... (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: threadpool: Handle worker thread transitioning to dead when going active.
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/1602/4/main/threadpool.c
File main/threadpool.c:

Line 1158: 		/* This can occur due to a race condition between being told to go active
         : 		 * and an idle timeout happening.
         : 		 */
Is there any way to prevent that race condition from occurring in the first place?

That is, should the thread that is telling the worker to go active also hold the locks for the idle container (or whatever lock is appropriate) to prevent the idle timeout from making progress?


-- 
To view, visit https://gerrit.asterisk.org/1602
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c455f9a40de60d9e86458d447b548fb52ba1143
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes