[Asterisk-code-review] threadpool: Handle worker thread transitioning to dead when ... (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: threadpool: Handle worker thread transitioning to dead when going active.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/1602/3/main/threadpool.c
File main/threadpool.c:

Line 1155: 	/* If the worker is already dead then no subsequent transitions are permitted */
I would suspect that it is an error to do any one of the following:

* Transition from ALIVE to DEAD directly
* Transition from ZOMBIE to ALIVE
* Transition from DEAD to anything

If so, we really should have an assert for those. With DO_CRASH, it would be much easier to catch who the offender is in violating the state machine.


-- 
To view, visit https://gerrit.asterisk.org/1602
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c455f9a40de60d9e86458d447b548fb52ba1143
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes