[Asterisk-code-review] threadpool: Handle worker thread transitioning to dead when ... (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Wed Nov 11 12:36:22 CST 2015


Richard Mudgett has posted comments on this change.

Change subject: threadpool: Handle worker thread transitioning to dead when going active.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1602/2/tests/test_threadpool.c
File tests/test_threadpool.c:

Line 633: 		while (ast_cond_timedwait(&tld->cond, &tld->lock, &end) != ETIMEDOUT);
Use curlies instead of an easy to miss semicolon on the end of the line.  Using curlies also emphasizes that the loop body is empty.


-- 
To view, visit https://gerrit.asterisk.org/1602
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c455f9a40de60d9e86458d447b548fb52ba1143
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list