[Asterisk-code-review] rtp engine: Init a format-attribute module to its RFC defaults. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Wed Nov 11 07:29:11 CST 2015


Joshua Colp has posted comments on this change.

Change subject: rtp_engine: Init a format-attribute module to its RFC defaults.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1593/1/main/rtp_engine.c
File main/rtp_engine.c:

Line 730: 			new_type->format = ast_format_g726_aal2;
        : 		} else {
        : 			new_type->format = t->payload_type.format;
        : 		}
        : 		if (new_type->format) {
        : 			new_type->format = ast_format_parse_sdp_fmtp(new_type->format, "");
        : 		}
Add a comment explaining why the removal of the ao2_bump is correct for the next person who comes across this.


-- 
To view, visit https://gerrit.asterisk.org/1593
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f680cef7fdf51c0969ff8da71548edad72ec52
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list