[Asterisk-code-review] format: Register format-attribute module with cached formats. (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: format: Register format-attribute module with cached formats.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1600/1/main/format.c
File main/format.c:

Line 162: 	cached = ast_format_cache_get(codec);
        : 	if (cached) {
        : 		cached->interface = format_interface->interface;
        : 	}
> This is dangerous. Formats are immutable once created and have no protectio
The format-attribute modules are loaded quite early. I am not aware of an issue. 

Anyway, if you do not like this patch, please, have a look at the original issue report ASTERISK-25160 and comment on the alternative patch. Furthermore, a third alternative exist: Changing the order of module load, so that while the cached formats are created the format-modules are available already.


-- 
To view, visit https://gerrit.asterisk.org/1600
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ea1f0483e5261e2a050112e4ebdfc22057d1354
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes