[Asterisk-code-review] Remove ABI compatibility stub functions. (asterisk[master])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged.

Change subject: Remove ABI compatibility stub functions.
......................................................................


Remove ABI compatibility stub functions.

ABI compatibility stubs existed for ast_app_separate_args and ast_verbose,
this is not needed in master.

Change-Id: I07b4d2c16079da3c2c6efa55df4a74368e0bd453
---
M main/app.c
M main/logger.c
2 files changed, 0 insertions(+), 24 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/main/app.c b/main/app.c
index 2046ac8..dabf15d 100644
--- a/main/app.c
+++ b/main/app.c
@@ -2098,9 +2098,6 @@
 	return AST_RWLIST_UNLOCK(&groups);
 }
 
-#undef ast_app_separate_args
-unsigned int ast_app_separate_args(char *buf, char delim, char **array, int arraylen);
-
 unsigned int __ast_app_separate_args(char *buf, char delim, int remove_chars, char **array, int arraylen)
 {
 	int argc;
@@ -2163,12 +2160,6 @@
 	}
 
 	return argc;
-}
-
-/* ABI compatible function */
-unsigned int ast_app_separate_args(char *buf, char delim, char **array, int arraylen)
-{
-	return __ast_app_separate_args(buf, delim, 1, array, arraylen);
 }
 
 static enum AST_LOCK_RESULT ast_lock_path_lockfile(const char *path)
diff --git a/main/logger.c b/main/logger.c
index a5925e4..73b8ee1 100644
--- a/main/logger.c
+++ b/main/logger.c
@@ -2144,21 +2144,6 @@
 	va_end(ap);
 }
 
-/* No new code should use this directly, but we have the ABI for backwards compat */
-#undef ast_verbose
-void __attribute__((format(printf, 1,2))) ast_verbose(const char *fmt, ...);
-void ast_verbose(const char *fmt, ...)
-{
-	ast_callid callid;
-	va_list ap;
-
-	callid = ast_read_threadstorage_callid();
-
-	va_start(ap, fmt);
-	__ast_verbose_ap("", 0, "", 0, callid, fmt, ap);
-	va_end(ap);
-}
-
 /*! Console verbosity level node. */
 struct verb_console {
 	/*! List node link */

-- 
To view, visit https://gerrit.asterisk.org/1596
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07b4d2c16079da3c2c6efa55df4a74368e0bd453
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>