[Asterisk-code-review] Testsuite: Refactored 'rls validation' Module for Easier Deb... (testsuite[master])

Ashley Sanders asteriskteam at digium.com
Tue Nov 10 09:54:05 CST 2015


Hello Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/1537

to look at the new patch set (#2).

Change subject: Testsuite: Refactored 'rls_validation' Module for Easier Debugging
......................................................................

Testsuite: Refactored 'rls_validation' Module for Easier Debugging

While this does not actually correct the issue with the test failure (which
incidentally turns out is not localized to this test), this patch modifies the
the test validator by separating the concerns for each validation method,
improving the logging, and fixing pylint issues.

This is part four (4) of an n-patch series of refactorings to help determine the
root cause of the test failure and correct pylint issues.

ASTERISK-25430
Reported By: Ashley Sanders

Change-Id: Icb8af439f5c3db3efb0a93d6402ab4dcacdf3731
---
A tests/channels/pjsip/subscriptions/rls/rls_element.py
D tests/channels/pjsip/subscriptions/rls/rls_integrity.py
M tests/channels/pjsip/subscriptions/rls/rls_test.py
A tests/channels/pjsip/subscriptions/rls/rls_validation.py
4 files changed, 1,281 insertions(+), 437 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/37/1537/2
-- 
To view, visit https://gerrit.asterisk.org/1537
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icb8af439f5c3db3efb0a93d6402ab4dcacdf3731
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>



More information about the asterisk-code-review mailing list