[Asterisk-code-review] rtp engine: Init a format-attribute module to its RFC defaults. (asterisk[13])

[Alexander Traud]

Alexander Traud has uploaded a new change for review.

  https://gerrit.asterisk.org/1593

Change subject: rtp_engine: Init a format-attribute module to its RFC defaults.
......................................................................

rtp_engine: Init a format-attribute module to its RFC defaults.

Previously, format-attribute modules relied on an existing fmtp line in SDP
negotiation. However, fmtp is optional for several formats like the Opus Codec.
Now, the format-attribute module is called with an empty fmtp, which allows the
module to initialise itself to RFC defaults. Furthermore now, Asterisk is able
to differentiate between internally and externally created formats.

ASTERISK-25537 #close

Change-Id: I28f680cef7fdf51c0969ff8da71548edad72ec52
---
M main/rtp_engine.c
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/93/1593/1

diff --git a/main/rtp_engine.c b/main/rtp_engine.c
index 8ad3d9e..c9921bd 100644
--- a/main/rtp_engine.c
+++ b/main/rtp_engine.c
@@ -727,9 +727,12 @@
 		new_type->rtp_code = t->payload_type.rtp_code;
 		if ((ast_format_cmp(t->payload_type.format, ast_format_g726) == AST_FORMAT_CMP_EQUAL) &&
 				t->payload_type.asterisk_format && (options & AST_RTP_OPT_G726_NONSTANDARD)) {
-			new_type->format = ao2_bump(ast_format_g726_aal2);
+			new_type->format = ast_format_g726_aal2;
 		} else {
-			new_type->format = ao2_bump(t->payload_type.format);
+			new_type->format = t->payload_type.format;
+		}
+		if (new_type->format) {
+			new_type->format = ast_format_parse_sdp_fmtp(new_type->format, "");
 		}
 		AST_VECTOR_REPLACE(&codecs->payloads, pt, new_type);
 

-- 
To view, visit https://gerrit.asterisk.org/1593
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28f680cef7fdf51c0969ff8da71548edad72ec52
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>