[Asterisk-code-review] ast format cap get names: To display all formats, the buffer... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: ast_format_cap_get_names: To display all formats, the buffer was increased.
......................................................................


Patch Set 1:

> I am not an integrator, I am an external contributor. If you like
 > to have this patch extended in functionality and you do not have
 > the time to take-over this change, please, give me precise
 > information where, in which source to add this DEFINE.

I would add to format_cap.h near ast_format_cap_get_names:
#ifndef AST_FORMAT_CAP_NAMES_LEN
/*! Buffer size for callers of ast_format_cap_get_names to allocate. */
#define AST_FORMAT_CAP_NAMES_LEN 384
#endif

The #ifndef guard is useful as it allows the default buffer length to be overridden by build scripts.  For example small embedded ulaw only systems could define a smaller buffer.

-- 
To view, visit https://gerrit.asterisk.org/1588
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I590a3f7232cecc1dcd4fffe49525266a7a777c80
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: No