[Asterisk-code-review] main/file.c: Add debug where is searched file in filehelper ... (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: main/file.c: Add debug where is searched file in filehelper function
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Could this be solved with documentation about the search process?

https://gerrit.asterisk.org/#/c/1586/1/main/file.c
File main/file.c:

Line 528: 			ast_log(LOG_DEBUG, "Search file %s \n", fn);
I think this will produce too much output (even for debug).  This debug is inside a double loop.  Also filehelper is called at least twice per run of ast_openstream_full.  Once directly, once by fileexists_core / fileexists_test.

Also for future reference you generally should not use LOG_DEBUG.  It would be better to use: ast_debug(4, "Search file %s\n", fn);


-- 
To view, visit https://gerrit.asterisk.org/1586
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea667ee6625657cb82be26773517b1a2d054db3b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes