[Asterisk-code-review] taskprocessor: Add high water mark warnings (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Thu Nov 5 15:59:48 CST 2015


Richard Mudgett has posted comments on this change.

Change subject: taskprocessor: Add high water mark warnings
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1562/3//COMMIT_MSG
Commit Message:

Line 13: grows above 40 queued tasks that it will emit a warning message.
s/40/100/


https://gerrit.asterisk.org/#/c/1562/3/main/taskprocessor.c
File main/taskprocessor.c:

Line 742: 		ast_log(LOG_WARNING, "Long queue of scheduled tasks (%d) reached for task processor '%s'\n",
The log message doesn't read right.  How about:
"The '%s' task processor queue reached %d scheduled tasks.\n"


-- 
To view, visit https://gerrit.asterisk.org/1562
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1607c35d18c1d6a0575b3f0e3ff5d932fd6600c
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list